Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VEText Forwarder Lambda Logging #1497

Closed
9 tasks done
k-macmillan opened this issue Oct 17, 2023 · 2 comments
Closed
9 tasks done

Update VEText Forwarder Lambda Logging #1497

k-macmillan opened this issue Oct 17, 2023 · 2 comments

Comments

@k-macmillan
Copy link
Member

k-macmillan commented Oct 17, 2023

User Story - Business Need

Update the logging in the vetext forwarder lambda to be in-line with our logging policy.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA Notify Engineer
I want to log in accordance with our policies
So that we are consistent across the platform

Additional Info and Resources

Engineering Checklist

  • All logging includes string qualifiers (nothing like logger.info(event))
  • Proper use of info, warning, and error/critical
  • MessageSid is recorded in the logs
  • MessagingServiceSid is recorded in the logs
  • To (the service's phone number) is recorded in the logs
  • From and other identifying fields are not recorded outside of debug logging

Acceptance Criteria

  • Code not related to logging is not changed at all
  • Logging output coincides with the logging policy

QA Considerations

Logging has no opportunity for new errors

@mjones-oddball
Copy link

@npmartin-oddball
Copy link

@k-macmillan will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants