Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1497 Update logging for the Vetext forwarder lambda #2199

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

kalbfled
Copy link
Member

Description

These changes update logging for the Vetext forwarder lambda to bring it into compliance with our logging document. Note that using logger.exception logs at the "Error" level and includes the stack trace in the output.

issue #1497

How Has This Been Tested?

I deployed the branch with lambdas and let the regressions run.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@kalbfled kalbfled added the patch label Dec 23, 2024
@kalbfled kalbfled self-assigned this Dec 23, 2024
@kalbfled kalbfled marked this pull request as ready for review December 23, 2024 23:53
@kalbfled kalbfled requested a review from a team as a code owner December 23, 2024 23:53
Copy link
Member

@k-macmillan k-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning 403 on unauthenticated Twilio request for event should be a warning.
We should log the unsuccessful request responses from VEText in the make_vetext_request method.
Unable to encrypt/json dump error logging should be exception.

@k-macmillan k-macmillan merged commit 6f2f7ef into main Dec 24, 2024
5 checks passed
@k-macmillan k-macmillan deleted the 1497-lambda-logging branch December 24, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants