Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf & Staging: Configure the send email notification delivery status to VA Profile #1779

Closed
7 of 8 tasks
MackHalliday opened this issue May 2, 2024 · 8 comments
Closed
7 of 8 tasks

Comments

@MackHalliday
Copy link

MackHalliday commented May 2, 2024

User Story - Business Need

We want to improve the management and reliability of email data within the VA system in collaboration with VA Profile by

  • Tracking delivered and bounced emails, specifically identifying hard bounces (permanent failures) and soft bounces (temporary issues).
  • VA Notify will support VA Profile by providing real-time data on email deliverability.
  • Utilizing existing infrastructure and celery tasks to minimize new development efforts.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA Notify Developer,
I want properly configure and test new feature to send email notification delivery status to VA Profile in the Staging environment.
So that we can ensure the new feature functions as expected in the Staging environment.

Additional Info and Resources

Engineering Checklist

  • Confirm bearer token ssm parameter is populated for both perf/staging
  • Enable feature flag in Perf & Staging environments
  • Coordinate with VA Profile to conduct integration tests.
    • Verify that POST requests send accurate and complete email delivery status data.
    • Ensure error handling processes are properly logging and managing errors.
    • Obtain QA approval after successful testing of all scenarios in the Perf & Staging environment.

Acceptance Criteria

  • The new features can send delivery status data on ALL email notifications
  • Any errors, whether expected or unexpected, are logged and handled gracefully
  • Feature flag (VA_PROFILE_EMAIL_STATUS_ENABLED) work is coordinated with IIR team to avoid collisions

QA Considerations

  • Shadow the VAProfile testing
@cris-oddball cris-oddball changed the title Staging: Configure and test new feature to send email notification delivery status to VA Profile in Staging Staging: Configure the send email notification delivery status to VA Profile May 2, 2024
@cris-oddball
Copy link

@mjones-oddball mjones-oddball changed the title Staging: Configure the send email notification delivery status to VA Profile Perf & Staging: Configure the send email notification delivery status to VA Profile Jul 24, 2024
@mjones-oddball
Copy link

Tagged as blocked because we are awaiting VA Profile to provide the QA endpoint (est date - 8/13).

@EvanParish
Copy link

This is just enabling a feature flag for work that has already be completed and verifying it works in the logs. It should be pointed at a 1, or 2 depending on the coordination effort Kyle went through with VA Profile already to verify the endpoint is set up.

@mjones-oddball
Copy link

@EvanParish looks like Kyle spent ~30 minutes validating and that included reverting. Should we repoint the prod ticket - #1780? It's currently at a 2. CC @npmartin-oddball @kbelikova-oddball

@cris-oddball
Copy link

PR approved and merged, sending via pipeline. Previously validated in Perf.

@EvanParish
Copy link

@mjones-oddball Since it's working in all other environments all we need is the token from them to put in AWS SSM and the green light to push this to Prod. I think 1 point should be sufficient for that. I'd recommend re-pointing to a 1.

@EvanParish
Copy link

It looks like everything is working as expected. The only errors we would expect to see would come from making the request to VA Profile and those are caught and logged. I'm not sure how we would force those to happen, so I haven't checked the box for: Ensure error handling processes are properly logging and managing errors.

We use the requests library frequently though, so there's not much uncertanty in the type of errors we would see there.

@EvanParish
Copy link

Closing since perf / staging look good and this has been deployed to Prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants