update role allowances for aria-expanded [WIP]

[scottaohara]

All roles reviewed to largely remove (but in a few cases add) aria-expanded as a supported attribute.

This matches both work done in ARIA 1.2 to correct for roles that should not have allowed the attribute, while also incorporating some ARIA 1.2 updates where some roles had support for the attribute added.

closes #3339

[WilcoFiers]

I'm a little hesitant to just pull attributes. I would prefer to flag them as deprecated. I'm not entirely sure how to do this. Perhaps a new check is needed for that. I'll talk to Steve about this. It's looking like axe-core 4.5 is going to get a more "sync with latest standards" focus, so I think we'll include it in that. I'll leave this open while we finish up 4.4 (3 more weeks).

[scottaohara]

just for my own clarity, you mean that axe would want to report these as deprecated, even though their removal isn't an actual deprecation by the spec, but rather a fix for erroneously marking their use on these roles as allowed?

and understood on the timetable. I made this PR knowing you had said it wouldn't make it into 4.4.

[WilcoFiers]

@scottaohara That's what I'm thinking. More importantly, I don't want to just remove them like this PR is doing. I'm concerned this is going to be perceived as a regression. I think this needs some kind message explicitly calling out the change in the standard. Perhaps we make this more of a "deprecated or removed" type message, but something so that users don't think axe-core broke on them.

I would've preferred ARIA WG deprecate these TBH, but we're probably well passed the point that that's a reasonable request to make. This change is pretty well locked into 1.2.

[scottaohara]

That all makes sense. Thanks.

I’ll leave this PR open in case y’all want to use it as a quick reference to grab all the roles where aria-expanded was removed (and the few where it was added). But otherwise feel free to close it down, and again thanks for the explanation.

[querkmachine]

Hello!

In the GOV.UK Design System we use aria-expanded for our conditional checkbox pattern. Services using the Design System frequently receive feedback from accessibility auditors using Axe that this is a violation, as Axe hasn't been updated to incorporate this part of ARIA 1.2 yet.

Just thought I'd give a poke as the original target of version 4.5 seems to have passed without comment.

Thanks!

[colinrotherham]

@querkmachine Confirmed fixed with @axe-core/puppeteer now including axe-core ^4.7.2 ~4.8.2

• Bump the test group with 1 update alphagov/govuk-frontend#4335

Thanks all