Skip to content

Commit

Permalink
fix #17
Browse files Browse the repository at this point in the history
  • Loading branch information
Raphael Petrini committed Nov 15, 2016
1 parent 523c0e4 commit e89e103
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@ http://www.magentocommerce.com/magento-connect/abandoned-carts-notifications.htm

# Release Notes

## 1.0.7
Thanks to Septoctobre for all the bug reports and pull requests

- Fix a bug where the delay would not be taken into consideration when the cron ran: https://github.com/digitalpianism/abandonedcarts/issues/17
- Fix a bug where the area would not be properly loaded: https://github.com/digitalpianism/abandonedcarts/issues/8 and https://github.com/digitalpianism/abandonedcarts/issues/7
- Fix a bug where the count of total would be wrong because of the quantity : https://github.com/digitalpianism/abandonedcarts/issues/13
- Implement prices columns with currencies : https://github.com/digitalpianism/abandonedcarts/issues/13
- Fix a bug where the sale abandoned carts report would display nothing when flat catalog is enabled : https://github.com/digitalpianism/abandonedcarts/issues/15

## 1.0.6
- Fix a bug where an error would be triggered when filtering the grid by one date (from OR to) : https://github.com/digitalpianism/abandonedcarts/issues/9
- Fix a bug where the count in the grid would be wrong: https://github.com/digitalpianism/abandonedcarts/issues/11
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ protected function _sendEmails($dryrun, $testemail)
* @param boolean
* @param string
*/
public function sendAbandonedCartsSaleEmail($dryrun = false, $testemail = null, $emails = array())
public function sendAbandonedCartsSaleEmail(Mage_Cron_Model_Schedule $schedule = null, $dryrun = false, $testemail = null, $emails = array())
{
if (Mage::helper('abandonedcarts')->getDryRun()) {
$dryrun = true;
Expand Down Expand Up @@ -530,7 +530,7 @@ public function sendAbandonedCartsSaleEmail($dryrun = false, $testemail = null,
* @param string $testemail
* @internal param if $boolean dryrun is set to true, it won't send emails and won't alter quotes
*/
public function sendAbandonedCartsEmail($nodate = false, $dryrun = false, $testemail = null, $emails = array())
public function sendAbandonedCartsEmail(Mage_Cron_Model_Schedule $schedule = null, $nodate = false, $dryrun = false, $testemail = null, $emails = array())
{
if (Mage::helper('abandonedcarts')->getDryRun()) {
$dryrun = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public function notifySaleAction()
Mage::getSingleton('adminhtml/session')->addError(Mage::helper('abandonedcarts')->__('Please select email(s)'));
} else {
try {
Mage::getModel('abandonedcarts/notifier')->sendAbandonedCartsSaleEmail(false, false, $emails);
Mage::getModel('abandonedcarts/notifier')->sendAbandonedCartsSaleEmail(null, false, false, $emails);
Mage::getSingleton('adminhtml/session')->addSuccess(
Mage::helper('abandonedcarts')->__(
'%sTotal of %d customer(s) were successfully notified', (Mage::helper('abandonedcarts')->getDryRun() ? "!DRY RUN! " : ""), count($emails)
Expand All @@ -119,7 +119,7 @@ public function notifyAction()
Mage::getSingleton('adminhtml/session')->addError(Mage::helper('abandonedcarts')->__('Please select email(s)'));
} else {
try {
Mage::getModel('abandonedcarts/notifier')->sendAbandonedCartsEmail(false, false, null, $emails);
Mage::getModel('abandonedcarts/notifier')->sendAbandonedCartsEmail(null, false, false, null, $emails);
Mage::getSingleton('adminhtml/session')->addSuccess(
Mage::helper('abandonedcarts')->__(
'%sTotal of %d customer(s) were successfully notified', (Mage::helper('abandonedcarts')->getDryRun() ? "!DRY RUN! " : ""), count($emails)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<modules>
<DigitalPianism_Abandonedcarts>
<version>1.0.6</version>
<version>1.0.7</version>
</DigitalPianism_Abandonedcarts>
</modules>

Expand Down

0 comments on commit e89e103

Please sign in to comment.