Make DebugToolarMiddleware compatible with Django 1.10's MIDDLEWARE setting #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 75.52% (diff: 88.88%)@@ master #864 diff @@
==========================================
Files 30 30
Lines 1654 1659 +5
Methods 0 0
Messages 0 0
Branches 246 246
==========================================
+ Hits 1248 1253 +5
Misses 327 327
Partials 79 79
|
12 tasks
* jdufresne/fix-test-warning: Add SessionAuthenticationMiddleware to test settings.py to silence warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Refs #853.)
I'd very much appreciate additional guidance on required tests and/or docs. Modifying
tests/settings.pyto contain MIDDLEWARE instead of MIDDLEWARE_CLASSES does not work (obviously).Thanks for the project, and thanks for your time.