Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure CRAB job Wrapper does not use WMCore CMSSW executor #7215

Closed
belforte opened this issue Apr 19, 2022 · 7 comments
Closed

make sure CRAB job Wrapper does not use WMCore CMSSW executor #7215

belforte opened this issue Apr 19, 2022 · 7 comments

Comments

@belforte
Copy link
Member

in particular this part about USER_TARBALL
https://github.com/dmwm/WMCore/blob/748fb8df96a9328600b254b934c8f96ced00505c/src/python/WMCore/WMSpec/Steps/Executors/CMSSW.py#L404

@belforte belforte self-assigned this Apr 19, 2022
@belforte
Copy link
Member Author

@mapellidario @khurtado FYI

@belforte
Copy link
Member Author

belforte commented Apr 19, 2022

CRAB stopped using WMCore CMSSW executor in August 2021
b28897e
There is no reference to $USER_TARBALL anymore
@khurtado go ahead with your cleanup and let us know when there's a new WMCore tag to check

@belforte
Copy link
Member Author

If you agree, I will close.

@khurtado
Copy link

khurtado commented Apr 19, 2022

Thank you @belforte ! (and yes, the CRAB issue can be closed, I will close the WMCore issue once we remove those lines in the code)

@khurtado
Copy link

@belforte I made the following PR removing $USER_TARBALL and $USER_FILES from it.

dmwm/WMCore#11114

But I am also deleting this file and I just wanted to be sure CRAB indeed doesn't use this file at all (I couldn't find any reference here to it other than old github issues)
https://github.com/dmwm/WMCore/blob/f5f71549d5ebb6befd794049b5518cfd179d2c7d/src/python/WMCore/WMRuntime/Scripts/UnpackUserTarball.py

@belforte
Copy link
Member Author

thanks for cheking @khurtado . Yes, no problem, that's not used anywhere. Looks like some old thing from pre-HTCondor times when job wrappers had to pull tarballs themselves from some central storage.

@khurtado
Copy link

@belforte Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants