Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate or Re-implement support for user tarballs (used by CRAB) #10442

Closed
khurtado opened this issue Apr 12, 2021 · 1 comment · Fixed by #11114
Closed

Deprecate or Re-implement support for user tarballs (used by CRAB) #10442

khurtado opened this issue Apr 12, 2021 · 1 comment · Fixed by #11114
Assignees
Labels
New Feature Technical Debt Used to track issues that address technical needs internal to WM team WMAgent

Comments

@khurtado
Copy link
Contributor

khurtado commented Apr 12, 2021

Impact of the new feature
Simplify cmssw step deprecating support of python-based user tarballs unpacking.

Is your feature request related to a problem? Please describe.
We use some python-based code living in WMCore in the bash script we use to execute cmsRun. We want to decouple cmsRun from WMCore and this script that lives in WMCore, would be executed using the CMSSW python version

Describe the solution you'd like
We don't use this in production, but we should make sure CRAB is not using it either so we can deprecate its use. Otherwise, we could likely re-implement this script in full-bash, so it doesn't depend on any python version.

Note: This is where CRAB seems to use it.
https://github.com/dmwm/CRABServer/blob/dc26ef6512e5c75cf7ce0106f9838e63b870dac1/scripts/CMSRunAnalysis.py#L886
https://github.com/dmwm/CRABServer/blob/dc26ef6512e5c75cf7ce0106f9838e63b870dac1/scripts/CMSRunAnalysis.py#L740

Additional context
Although this is sort of related to python2/3 migration, it does not affect production but CRAB, as we don't call this part of the code in production, so we can deal with this later on

@khurtado khurtado changed the title Deprecate support for user tarballs Deprecate or Re-implement support for user tarballs (used by CRAB) Apr 12, 2021
@khurtado
Copy link
Contributor Author

As mentioned in:

dmwm/CRABServer#7215 (comment)

This is not used by CRAB anymore and we can now get rid of these lines:

if [ -n "$USER_TARBALL" ] ; then
python2 -m WMCore.WMRuntime.Scripts.UnpackUserTarball $USER_TARBALL $USER_FILES
EXIT_STATUS=$?
if [ $EXIT_STATUS -ne 0 ]; then
echo "***\nCouldn't untar sandbox with python2: $EXIT_STATUS\n";
echo "***\nWill try with python2.6 as it might be an old CMSSW release!"
python2.6 -m WMCore.WMRuntime.Scripts.UnpackUserTarball $USER_TARBALL $USER_FILES
EXIT_STATUS=$?
if [ $EXIT_STATUS -ne 0 ]; then
echo "***\nCouldn't untar sandbox with python2.6: $EXIT_STATUS\n";
exit 74;
fi
fi
fi

@khurtado khurtado self-assigned this Apr 19, 2022
@amaltaro amaltaro added WMAgent Technical Debt Used to track issues that address technical needs internal to WM team labels Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature Technical Debt Used to track issues that address technical needs internal to WM team WMAgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants