Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Unpacking user tarballs. No longer used by CRAB. #11114

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

khurtado
Copy link
Contributor

@khurtado khurtado commented Apr 25, 2022

Fixes #10442

Status

ready

Description

This gets rid of the user tarball unpacking support, which was calling it via python2 and is no longer used by CRAB.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Related CRAB issue:
dmwm/CRABServer#7215

Where it's confirmed the user tarballs python script isn't used by CRAB anymore

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests deleted
    • 7 tests added
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 2 warnings
    • 9 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13075/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests deleted
    • 7 tests added
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 2 warnings
    • 9 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13094/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

@khurtado I am not sure whether you are still working on this, but it's looking good to me and we could have it in a release for tomorrow (well, cmsweb services release). Please let me know.

@khurtado khurtado requested a review from amaltaro April 28, 2022 02:04
@khurtado
Copy link
Contributor Author

@amaltaro Yes! I tested locally but besides the bash wrapper changes, I wanted to be sure CRAB isn't using the UnpackUserTarball.py file anywhere either. Since Stefano confirmed they don't, I think we can proceed with this PR approval

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! It looks good to me then! Thanks Kenyi.

@amaltaro amaltaro merged commit 23ab38d into dmwm:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate or Re-implement support for user tarballs (used by CRAB)
3 participants