We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impact of the new feature
Likely to involve a large portion of the codebase.
Is your feature request related to a problem? Please describe.
The "python3 compatibility report" section of the Jenkins report often suggests the following change, in order not to use a pre-py2.6 idiom:
- if type(variable) == mytype: + if isinstance(variable, mytype):
Since these are almost always safe changes, they can be tackled all at once.
Describe the solution you'd like
We should apply the changes suggested by the "python3 compatibility report" regarding pre-py2.6 idioms once and for all.
Additional context
This issue was suggested in the comments section of #10103
The text was updated successfully, but these errors were encountered:
[py2py3] fix pre-py2.6: type() == -> isinstance
type() ==
isinstance
5f9d91e
issue dmwm#10171, PR dmwm#10172
b558077
issue #10171, PR #10172
3c15cc2
mapellidario
Successfully merging a pull request may close this issue.
Impact of the new feature
Likely to involve a large portion of the codebase.
Is your feature request related to a problem? Please describe.
The "python3 compatibility report" section of the Jenkins report often suggests the following change, in order not to use a pre-py2.6 idiom:
Since these are almost always safe changes, they can be tackled all at once.
Describe the solution you'd like
We should apply the changes suggested by the "python3 compatibility report" regarding pre-py2.6 idioms once and for all.
Additional context
This issue was suggested in the comments section of #10103
The text was updated successfully, but these errors were encountered: