[py2py3] Migration at level scr/python/A/B/C - slice 2 #10103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapellidario
added
Python3
PR: Do not merge yet
PR: Work in progress
py2py3 slice
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
mapellidario
force-pushed
the
py2py3-issue10098
branch
from
c9e2ce2 to
8ede6c1
Compare
|
Jenkins results:
|
|
Jenkins results:
|
mapellidario
force-pushed
the
py2py3-issue10098
branch
2 times, most recently
from
47aa086 to
322c452
Compare
|
Jenkins results:
|
|
Jenkins results:
|
mapellidario
force-pushed
the
py2py3-issue10098
branch
from
322c452 to
d33b43c
Compare
|
Jenkins results:
|
mapellidario
force-pushed
the
py2py3-issue10098
branch
from
0f36b00 to
3868fbd
Compare
|
Jenkins results:
|
|
Jenkins results:
|
mapellidario
requested review from
amaltaro
and removed request for
amaltaro
mapellidario
force-pushed
the
py2py3-issue10098
branch
from
6e915a9 to
7028010
Compare
|
@amaltaro after discussion on slack, this has been rebased directly onto master and it is ready to be reviewed! |
mapellidario
force-pushed
the
py2py3-issue10098
branch
2 times, most recently
from
e1597cd to
48d3038
Compare
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
amaltaro
approved these changes
Dec 10, 2020
| @@ -112,6 +108,6 @@ def __str__(self): | |||
| """ | |||
| string = '' | |||
| for i in self.create, self.constraints, self.inserts, self.indexes: | |||
| for j in i.keys(): | |||
| for j in i: | |||
There was a problem hiding this comment.
such a horrible variable naming... nothing for you to do though!
|
Actually, can you please squash commits 2 and 3? |
mapellidario
force-pushed
the
py2py3-issue10098
branch
from
48d3038 to
e31c991
Compare
|
I squashed commit about After you give the ok, I can squash the commits about |
|
Jenkins results:
|
|
Thanks Dario. Feel free to squash the |
mapellidario
force-pushed
the
py2py3-issue10098
branch
from
e31c991 to
fa25507
Compare
|
Jenkins results:
|
|
Oups, I overlooked the python2.6 idioms. Have you tried updating those (at the very bottom of the PR report)? Or should we leave it for another PR? |
|
Since it is the usual |
|
@mapellidario Dario, I hope you haven't started working on this type x isinstance thing. |
This was referenced Jan 8, 2021
35 tasks
This was referenced May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10098
Status
ready
Related PRs
This PR is rebased on
master.Description
Run futurize and some manual changes on the first batch of src/python/A/B/C.
No notable changes or errors have been encountered during this PR.
Is it backward compatible (if not, which system it affects?)
It should be. No possible causes for errors have been spot by unit tests.
External dependencies / deployment changes
Requires python-future in both py2 and py3 environments.