Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove SiteDB, including emulators and tests #10280

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Feb 12, 2021

Fixes #9370

Status

ready

Description

This PR removes what was left of SiteDB in WMCore, including:

  • wrapper package
  • emulators
  • mock data
  • tests

Getting it done now such that there are less modules to be considered for the python3 code modernization.

Is it backward compatible (if not, which system it affects?)

yes (but no, APIs are removed from WMCore!)

Related PRs

none

External dependencies / deployment changes

none

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
    • 9 tests deleted
  • Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 6 warnings
    • 102 comments to review
  • Pylint py3k check: failed
    • 0 errors and warnings that should be fixed
    • 3 warnings
    • 0 comments to review
  • Pycodestyle check: succeeded
    • 27 comments to review
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11197/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

Easier than expected!
FYI @mapellidario this might have some impact on your planned slices.

@amaltaro amaltaro merged commit 1bb5623 into dmwm:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final removal of SiteDB code
2 participants