create/run: remove default --stop-signal #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
remove_stopsignal_default
branch
2 times, most recently
from
c6705b0
to
8197e8e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3245 +/- ##
=======================================
Coverage 57.98% 57.98%
=======================================
Files 302 302
Lines 21754 21753 -1
=======================================
+ Hits 12613 12614 +1
+ Misses 8218 8217 -1
+ Partials 923 922 -1 |
tianon
reviewed
Aug 18, 2021
man/docker-run.1.md
Outdated
| @@ -621,7 +621,7 @@ incompatible with any restart policy other than `none`. | |||
| For the `overlay2` storage driver, the size option is only available if the backing fs is `xfs` and mounted with the `pquota` mount option. | |||
| Under these conditions, user can pass any size less than the backing fs size. | |||
|
|
|||
| **--stop-signal**=*SIGTERM* | |||
| **--stop-signal**="" | |||
| Signal to stop a container. Default is SIGTERM. | |||
There was a problem hiding this comment.
Should this maybe note the fact that the default can be defined by the image or something? (STOPSIGNAL in Dockerfile)
Suggested change
| Signal to stop a container. Default is SIGTERM. | |
| Signal to stop a container. Default is defined by `STOPSIGNAL` in the image or `SIGTERM` if not defined. |
There was a problem hiding this comment.
Ah, yes, makes sense to add, let me add some of that; thanks!
thaJeztah
force-pushed
the
remove_stopsignal_default
branch
from
8197e8e
to
6671f40
Compare
|
I did some further rewriting of the docs, and moved a large part to #3261 (included in this PR; first two commits are from there) |
thaJeztah
commented
Aug 21, 2021
thaJeztah
force-pushed
the
remove_stopsignal_default
branch
from
6671f40
to
6d420ca
Compare
The DefaultStopSignal const has been deprecated, because the daemon already handles a default value. The current code did not actually send the default value unless the flag was set, which also made the flag description incorrect, because in that case, the _daemon's_ default would be used, which could potentially be different as was specified here. This patch removes the default value from the flag, leaving it to the daemon to set a default. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_stopsignal_default
branch
from
6d420ca
to
214cd05
Compare
|
@tianon @silvin-lubecki PTAL |
|
@silvin-lubecki PTAL 🤗 |
|
@silvin-lubecki @tonistiigi PTAL 🤗 |
jlecordier
pushed a commit
to jlecordier/cli
that referenced
this pull request
Dec 8, 2021
create/run: remove default --stop-signal Signed-off-by: jlecordier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to moby/moby#42717
The DefaultStopSignal const has been deprecated, because the daemon already
handles a default value. The current code did not actually send the default
value unless the flag was set, which also made the flag description incorrect,
because in that case, the daemon's default would be used, which could
potentially be different as was specified here.
This patch removes the default value from the flag, leaving it to the daemon
to set a default.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)