docker kill: don't set default signal on the client side #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Aug 25, 2021
thaJeztah
force-pushed
the
kill_canonical_signal_name
branch
from
c2cdfb9
to
711e6b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3271 +/- ##
=======================================
Coverage 58.24% 58.24%
=======================================
Files 287 287
Lines 24155 24155
=======================================
Hits 14070 14070
Misses 9225 9225
Partials 860 860 |
thaJeztah
force-pushed
the
kill_canonical_signal_name
branch
from
711e6b4
to
72e6f35
Compare
thaJeztah
changed the title
The default signal is already determined by the daemon, so the CLI should not send a signal. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
kill_canonical_signal_name
branch
from
72e6f35
to
20138a8
Compare
rumpl
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default signal is already determined by the daemon, so the CLI should not send a signal.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)