Postpone return type additions to 3.0 #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
revert-return-type-additions
branch
2 times, most recently
from
aef6c73 to
0dbcab3
Compare
They prevent writing compatibility layers that would work with version 1 and 2 easily.
greg0ire
force-pushed
the
revert-return-type-additions
branch
from
0dbcab3 to
76c8239
Compare
greg0ire
changed the title
|
If you feel some types should be made final or internal instead, please let me know. |
derrabus
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They prevent writing compatibility layers that would work with version 1 and 2 easily.
Prompted by doctrine/orm#10070
It might be interesting to review the new diff with the stable branch: 1.7.x...greg0ire:collections:revert-return-type-additions