Replace object-like array with class #79
Conversation
lib/Doctrine/Common/Lexer/Token.php
Outdated
| * @template T of string|int | ||
| * @implements ArrayAccess<string,mixed> | ||
| */ | ||
| final class Token implements ArrayAccess, Countable |
There was a problem hiding this comment.
🤔 I will remove Countable, as ArrayAccess should be enough to easily implement a forward-compatibility layer.
greg0ire
force-pushed
the
token-class
branch
2 times, most recently
from
e99786b to
65f3cdc
Compare
| * @template T of string|int | ||
| * @implements ArrayAccess<string,mixed> | ||
| */ | ||
| final class Token implements ArrayAccess |
There was a problem hiding this comment.
Although no BC-layer will be provided, implementing ArrayAccess should allow to easily make dependent packages compatible with lexer 1 and 2 at the same time.
|
We should try to ship this change in 1.x. It would be unfortunate if we needed to ship 2.x with a BC layer. |
I think we are going to need a 3.x very soon, because inheritance is involved: the ORM lexer extends the AbstractLexer, which means that if we add return type hints on 3.x, we will make it impossible for doctrine/orm to be compatible with both v1 and v2 at the same time, just like here: doctrine/collections#331 For that reason, I think it's not that big of a deal to have that BC layer on 2.x, since that series is supposed to be short-lived. If you can think of a way to ship this change in 1.x, I'm still interested though. |
|
I'm working on a solution to ship this in 1.x |
The new class is templatable, which should enable us to specify that the ORM Lexer is an Lexer<self::T_*>, and in the future, define an enum called TokenType in the ORM, and switch to Lexer<TokenType>.
|
ping @derrabus are you fine with this? |
| } | ||
|
|
||
| /** @param T ...$types */ | ||
| public function isA(...$types): bool |
There was a problem hiding this comment.
Hi mate! No it's isA, just like https://www.php.net/manual/en/function.is-a.php (but with several types) 🙂
By requiring `doctrine/lexer` v2 we can solve the following deprecation: ``` Accessing Doctrine\Common\Lexer\Token properties via ArrayAccess is deprecated, use the value, type or position property instead (Token.php:104 called by Parser.php:46, doctrine/lexer#79, package doctrine/lexer) ```
By requiring `doctrine/lexer` v2 we can solve the following deprecation: ``` Accessing Doctrine\Common\Lexer\Token properties via ArrayAccess is deprecated, use the value, type or position property instead (Token.php:104 called by Parser.php:46, doctrine/lexer#79, package doctrine/lexer) ```
By requiring `doctrine/lexer` v2 we can solve the following deprecation: ``` Accessing Doctrine\Common\Lexer\Token properties via ArrayAccess is deprecated, use the value, type or position property instead (Token.php:104 called by Parser.php:46, doctrine/lexer#79, package doctrine/lexer) ```
By requiring `doctrine/lexer` v2 we can solve the following deprecation: ``` Accessing Doctrine\Common\Lexer\Token properties via ArrayAccess is deprecated, use the value, type or position property instead (Token.php:104 called by Parser.php:46, doctrine/lexer#79, package doctrine/lexer) ```
The new class is templatable, which should enable us to specify that the
ORM Lexer is an
Lexer<self::T_*>, and in the future, define an enumcalled TokenType in the ORM, and switch to
Lexer<TokenType>.