Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced custom docker image for PostgreSQL with the official one #3447

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Replaced custom docker image for PostgreSQL with the official one #3447

merged 1 commit into from
Feb 3, 2019

Conversation

morozov
Copy link
Member

@morozov morozov commented Feb 3, 2019

Q A
Type improvement
BC Break no
Fixed issues job #488051004

@morozov morozov requested review from Majkl578 and Ocramius February 3, 2019 18:16
lcobucci
lcobucci approved these changes Feb 3, 2019
View reviewed changes
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's much nicer to not have to build the image during the build!

tests/travis/install-postgres-11.sh
sudo docker run -d --name postgres11 -p 5432:5432 postgres11
sudo docker exec postgres11 service postgresql start
sudo docker exec -i postgres11 su -c psql postgres <<<"create database doctrine_tests"
sudo docker run -d --name postgres11 -p 5432:5432 postgres:11.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using the alpine version would make us download a smaller image? If we do it we would probably not have bash (only sh), though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try using it if it shows visible performance improvement. Right now, I just chose the most default one to fix the build failure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always recommend against using Alpine-based images, they use different libc which causes problems for locale-based stuff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Majkl578 interesting, never had any issue 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iconv() is totally broken for example:
docker-library/php#240
nette/utils#109
https://github.com/search?q=alpine+iconv&type=Issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Majkl578 fun!

@morozov morozov added this to the 2.10.0 milestone Feb 3, 2019
@morozov morozov merged commit 1c75231 into doctrine:master Feb 3, 2019
@morozov morozov deleted the postgress-11 branch February 3, 2019 18:43
morozov added a commit that referenced this pull request Feb 9, 2019
@morozov
Merge branch 'bpo/2.9/#3447' into 2.9
741860d
@morozov morozov modified the milestones: 2.10.0, 2.9.3 Feb 9, 2019
@morozov morozov self-assigned this Feb 27, 2019
rgrellmann added a commit to Rossmann-IT/dbal that referenced this pull request Apr 22, 2020
@rgrellmann
Merge tag 'v2.9.3' into oracle122
65da389 
Release v2.9.3

[![Build Status](https://travis-ci.org/doctrine/dbal.svg?branch=v2.9.3)](https://travis-ci.org/doctrine/dbal)

This release fixes regressions introduced in previous releases and other bugs.

- Total issues resolved: **5**
- Total pull requests resolved: **14**
- Total contributors: **9**

**Regressions**

 - [3686: Fixed query result caching when `FetchMode::COLUMN` is used](doctrine#3686) thanks to @morozov and @Junker

 - [3456: Compare type class when comparing columns.](doctrine#3456) thanks to @garret-gunter and @cs278

**Other bugs**

 - [3679: fix begin trasaction after reconnect](doctrine#3679) thanks to @kalinin-k-a

 - [3547: Default column expressions do not work on SQL Server](doctrine#3547) thanks to @morozov

 - [3420: Index length can be a `string`: ensure that it is an integer when read by the `MySqlSchemaManager`](doctrine#3420) thanks to @leofeyer

**CI improvements and maintenance**

 - [3702: Updated SQL Server extensions to fix build failures on PHP 7.4](doctrine#3702) thanks to @morozov

 - [3662: Marked connection exception test incomplete on MySQL 8](doctrine#3662) thanks to @morozov

 - [3622: Switched from ibmcom/db2express-c to ibmcom/db2](doctrine#3622) thanks to @morozov

 - [3465: Replaced MySQL 5.7 installed from a PPA with an official Docker image](doctrine#3465) thanks to @morozov

 - [3454: CI: Test against PHP 7.4snapshot instead of nightly (8.0)](doctrine#3454) thanks to @Majkl578

 - [3452: Fixed AppVeyor build configuration and the issue on SQL Server](doctrine#3452) thanks to @morozov and @Majkl578

 - [3447: Replaced custom docker image for PostgreSQL with the official one](doctrine#3447) thanks to @morozov

 - [3407: CI: Test against MySQL 8.0 on Travis](doctrine#3407) thanks to @morozov

**PHP 7.4 support**

 - [3642: Fixed test failures on PHP 7.4](doctrine#3642) thanks to @morozov

# gpg: Signature made Sat Nov  2 23:20:42 2019
# gpg:                using RSA key 374EADAF543AE995
# gpg: Can't check signature: public key not found
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lcobucci lcobucci lcobucci approved these changes

@Majkl578 Majkl578 Awaiting requested review from Majkl578

@Ocramius Ocramius Awaiting requested review from Ocramius

Assignees

@morozov morozov

Labels
CI Improvement PostgreSQL
Projects
None yet
Milestone
2.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@morozov @Majkl578 @lcobucci