Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced custom docker image for PostgreSQL with the official one #3447

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Replaced custom docker image for PostgreSQL with the official one #3447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions tests/travis/Dockerfile-postgres11
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions tests/travis/install-postgres-11.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ echo "Preparing Postgres 11"

sudo service postgresql stop || true

sudo docker build -t postgres11 - < tests/travis/Dockerfile-postgres11
sudo docker run -d --name postgres11 -p 5432:5432 postgres11
sudo docker exec postgres11 service postgresql start
sudo docker exec -i postgres11 su -c psql postgres <<<"create database doctrine_tests"
sudo docker run -d --name postgres11 -p 5432:5432 postgres:11.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using the alpine version would make us download a smaller image? If we do it we would probably not have bash (only sh), though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try using it if it shows visible performance improvement. Right now, I just chose the most default one to fix the build failure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always recommend against using Alpine-based images, they use different libc which causes problems for locale-based stuff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Majkl578 interesting, never had any issue 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iconv() is totally broken for example:
docker-library/php#240
nette/utils#109
https://github.com/search?q=alpine+iconv&type=Issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Majkl578 fun!

sudo docker exec -i postgres11 bash <<< 'until pg_isready -U postgres > /dev/null 2>&1 ; do sleep 1; done'

echo "Postgres 11 ready"