Column with schemaDefinition equal to existing column in db keeps generating diff

[janedbal]

Q	A
Type	bug
Fixed issues	0

Summary

For some reason, AbstractPlatform is dropping columnDefinition when comparing columns. That causes issues of useless diffs being generated as shown in the failing test. Removing those two lines fixes this issue.

---

The real usecase I'm meeting is that our doctrine entity has discriminator column that needs manual setup of charset and collation and DiscriminatorColumn does not support the same options as regular Column (to provide charset and collation). With this bug, doctrine migrations keep generating new versions with no change inside.

[janedbal]

Worth to mention, that the testcase passes when you use old (deprecated) comparator approach

$comparator = new Comparator();
// instead of
$comparator = $this->schemaManager->createComparator();

Which is the way I detected this issue.

[janedbal]

@derrabus Would you accept PR with removal of those two lines? It looks like it breaks only 2 tests that test only that extact two lines and I dont really see reason to have it there.

[derrabus]

Those were added in #5224. Maybe that helps understanding the motivation behind them.

[janedbal]

Hm, that is really tricky. So my only saviour is probably this...

[morozov]

Those were added in #5224. Maybe that helps understanding the motivation behind them.

See #3647 (comment).

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[github-actions]

This pull request was closed due to inactivity.