Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options (charset, collation) to DiscriminatorColumn to align it with Column options #10462

Closed
janedbal opened this issue Jan 26, 2023 · 1 comment · Fixed by #10601
Closed

Add options (charset, collation) to DiscriminatorColumn to align it with Column options #10462

janedbal opened this issue Jan 26, 2023 · 1 comment · Fixed by #10601
Labels
Bug

Comments

@janedbal
Copy link
Contributor

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

As stated in related dbal issue, when trying to declare charset and collation for discriminator column, the only option to use is columnDefinition (which causes the migration issue described in the dbal issue). I believe that DiscriminatorColumn is not that much different from regular Column and it should support the same features.
@derrabus derrabus added the Bug label Jan 26, 2023
@janedbal janedbal mentioned this issue Feb 3, 2023
Closed
JanTvrdik added a commit to JanTvrdik/doctrine-orm that referenced this issue Mar 29, 2023
@JanTvrdik
Support options like charset and collation on DiscriminatedColumn
4c7789c 
[closes doctrine#10462]
@JanTvrdik JanTvrdik mentioned this issue Mar 29, 2023
Merged
JanTvrdik added a commit to JanTvrdik/doctrine-orm that referenced this issue Mar 29, 2023
@JanTvrdik
Support options like charset and collation on DiscriminatedColumn
f435baa 
[closes doctrine#10462]
JanTvrdik added a commit to JanTvrdik/doctrine-orm that referenced this issue Mar 29, 2023
@JanTvrdik
Support options like charset and collation on DiscriminatedColumn
dc3f3f7 
[closes doctrine#10462]
JanTvrdik added a commit to JanTvrdik/doctrine-orm that referenced this issue Mar 29, 2023
@JanTvrdik
Support options like charset and collation on DiscriminatedColumn
7f08f33 
[closes doctrine#10462]
JanTvrdik added a commit to JanTvrdik/doctrine-orm that referenced this issue Mar 30, 2023
@JanTvrdik
Support options like charset and collation on DiscriminatedColumn
7a53e72 
[closes doctrine#10462]
JanTvrdik added a commit to JanTvrdik/doctrine-orm that referenced this issue Mar 30, 2023
@JanTvrdik
Support options like charset and collation on DiscriminatedColumn
2f7ac47 
[closes doctrine#10462]
JanTvrdik added a commit to JanTvrdik/doctrine-orm that referenced this issue Mar 30, 2023
@JanTvrdik
Support options like charset and collation on DiscriminatedColumn
f215515 
[closes doctrine#10462]
@mattjanssen
Copy link

Was this resolved with #10601 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support options like charset and collation on DiscriminatedColumn JanTvrdik/doctrine-orm
4 participants
@greg0ire @mattjanssen @derrabus @janedbal