Migrate returns 0 as exit codes for empty plans as in 2.x #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enable alpha1 meaningful message when "latest" already reached.
In doctrine 2.x the migration command throws an exception if there are not migrations to execute (unless the --allow-no-migrations parameter is passed). In 3.0.0 this was misunderstood and the exception was thrown even if there are registered migrations but there are no migrations to execute for the current migration plan. With this commit we are back to the 2.x strategy. This commit also improves the error messages when the various aliases can not be reached or are already reached.
This was referenced Jun 20, 2020
greg0ire
reviewed
Jun 20, 2020
tests/Doctrine/Migrations/Tests/Tools/Console/Command/MigrateCommandTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/MigrateCommandTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/MigrateCommandTest.php
Outdated
Show resolved
Hide resolved
greg0ire
reviewed
Jun 20, 2020
tests/Doctrine/Migrations/Tests/Tools/Console/Command/MigrateCommandTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Grégoire Paris <[email protected]>
goetas
force-pushed
the
allow-no-migration
branch
from
562945f to
bd985d3
Compare
greg0ire
approved these changes
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In doctrine 2.x the migration command throws an exception if there
are not migrations to execute (unless the --allow-no-migrations
parameter is passed). In 3.0.0 this was misunderstood and the exception
was thrown even if there are registered migrations but there are no migrations to
execute for the current migration plan.
With this commit we are back to the 2.x strategy.
This commit also improves the error messages when the various aliases
can not be reached or are already reached.