Fix issue with some method when the migrations were not loaded #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aded Previously you needed to make sure manually that registerMigrations was called before to make any call to a method that was using the migrations loaded. This might cause performance issue in some edge case but it's unlikely. Unfortunately in the current desgin I don't see any other solution.
mikeSimonson
force-pushed
the
call-order
branch
from
7ca7e97 to
916bee2
Compare
|
@stof Can you review this change ? |
mikeSimonson
added a commit
that referenced
this pull request
Jan 17, 2016
Fix issue with some method when the migrations were not loaded
|
Awesome, I came across this issue many times! Thank you |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you needed to make sure manually that registerMigrations was
called before to make any call to a method that was using the migrations
loaded.
This might cause performance issue in some edge case but it's unlikely.
Unfortunately in the current desgin I don't see any other solution.