-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ExecuteCommand #433
Fix: ExecuteCommand #433
Conversation
@mikeSimonson review? |
@rcatlin Can you add a test for it ? |
@mikeSimonson Absolutely! |
@mikeSimonson Added tests for |
@rcatlin Thanks |
|
||
public function testGetVersionNotFound() | ||
{ | ||
$this->setExpectedException(MigrationException::class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting this after the call to getSqliteConfiguration
would be even better, as it would enforce the exception to happen in getVersion
rather than getSqliteConfiguration
(which is the drawback of the @expectedException
annotation btw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an excellent point! I'll put up a PR with the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Pull Request created #435
\Doctrine\DBAL\Migrations\Tools\Console\Command\ExecuteCommand
unable to find Migration Version by registering Migration Versions on call to\Doctrine\DBAL\Migrations\Configuration\Configuration#getVersion()
\Doctrine\DBAL\Migrations\Configuration\Configuration#getVersion()
\Doctrine\DBAL\Migrations\Configuration\Configuration#getVersion()