Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Command] Add option to Diff #784

Merged
merged 5 commits into from
Jan 22, 2019
Merged

[Command] Add option to Diff #784

merged 5 commits into from
Jan 22, 2019

Conversation

roukmoute
Copy link
Contributor

Q A
Type feature
BC Break no
Fixed issues #781

Summary

Add a new option check-database-platform to not generate a database platform code.

@roukmoute roukmoute mentioned this pull request Jan 22, 2019
Closed
@alcaeus alcaeus requested a review from greg0ire January 22, 2019 14:20
alcaeus
alcaeus requested changes Jan 22, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reopening! Only spotted one issue left over from @greg0ire's review in #782.

lib/Doctrine/Migrations/Tools/Console/Command/DiffCommand.php Show resolved Hide resolved
@roukmoute roukmoute force-pushed the improve_diff_command branch from 6581d04 to fa8aad1 Compare January 22, 2019 17:07
@alcaeus
Copy link
Member

alcaeus commented Jan 22, 2019

Thanks @roukmoute!

@alcaeus alcaeus merged commit cf7f94b into doctrine:master Jan 22, 2019
@alcaeus alcaeus self-assigned this Jan 22, 2019
@alcaeus alcaeus added this to the 2.1.0 milestone Jan 22, 2019
@roukmoute roukmoute deleted the improve_diff_command branch January 23, 2019 09:02
@andrew-demb andrew-demb mentioned this pull request Jun 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@alcaeus alcaeus alcaeus approved these changes

Assignees

@alcaeus alcaeus

Labels
Enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roukmoute @alcaeus @greg0ire @jwage