Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abortIf with an option in command #781

Closed
roukmoute opened this issue Jan 17, 2019 · 3 comments
Closed

Remove abortIf with an option in command #781

roukmoute opened this issue Jan 17, 2019 · 3 comments
Milestone

Comments

@roukmoute
Copy link
Contributor

roukmoute commented Jan 17, 2019

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

We have created our own template wich have a preUp and preDown.
Thoses methods use $this->abortIf(…).

So now this is not really necessary to keep this line in all our migration files: $this->abortIf($this->connection->getDatabasePlatform()->getName() !== 'postgresql', 'Migration can only be executed safely on \'postgresql\'.');

Do you accept a P.R. with a new option which if it is given it does not add this line?

@jwage
Copy link
Member

jwage commented Jan 17, 2019

Sure, we can include that as a new feature option in 2.1

@jwage jwage added this to the 2.1.0 milestone Jan 17, 2019
@roukmoute
Copy link
Contributor Author

roukmoute commented Jan 17, 2019

Ok cool!
So I will make a P.R. shortly.

@jwage
Copy link
Member

jwage commented Jan 17, 2019

Awesome! Be sure to include an update to the documentation here https://github.com/doctrine/migrations/blob/master/docs/en/reference/configuration.rst

roukmoute added a commit to roukmoute/migrations that referenced this issue Jan 17, 2019
roukmoute added a commit to roukmoute/migrations that referenced this issue Jan 17, 2019
roukmoute added a commit to roukmoute/migrations that referenced this issue Jan 18, 2019
roukmoute added a commit to roukmoute/migrations that referenced this issue Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants