-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle migrated versions metadata table auto-update #878
Conversation
@jwage From the git history, in 2.x you have implemented the https://github.com/doctrine/migrations/tree/2.2.x/lib/Doctrine/Migrations/Tracking feature, that was supposed to do something similar as this PR. Do you have time to review this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevent accidental merge, dismiss when second commit is removed
lib/Doctrine/Migrations/Metadata/Storage/TableMetadataStorage.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Metadata/Storage/TableMetadataStorage.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Metadata/Storage/TableMetadataStorage.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Tools/Console/Command/SyncMetadataCommand.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Tools/Console/Command/SyncMetadataCommand.php
Outdated
Show resolved
Hide resolved
e40c6fb
to
ffb671c
Compare
I think something went wrong with your last push, can you please check? None of my comments are addressed now… |
ffb671c
to
666b3eb
Compare
@greg0ire my bad I forgot to pull the changes done via github UI.
|
666b3eb
to
4eceb7b
Compare
Since this feature is quite critical, can somebody else review/test it please? |
@goetas I don't have any projects using migrations, and other people might be wondering this too: what would be the best way to test this? |
The best way to test this is to have a project using migrations 2.x, try the upgrade process to 3.x as described in https://github.com/doctrine/migrations/blob/master/UPGRADE.md, and share the results. |
4eceb7b
to
875b5de
Compare
Summary
This PR:
migrations:sync-metadata-storage
that ensure the table schemedoctrine_migrations
is always up to dateTheAllow phpunit 7.5
commit should be removed when #879 will be merged