Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop php 7.1 and allow phpunit 8 #879

Merged
merged 2 commits into from
Dec 1, 2019
Merged

Drop php 7.1 and allow phpunit 8 #879

merged 2 commits into from
Dec 1, 2019

Conversation

goetas
Copy link
Member

@goetas goetas commented Dec 1, 2019 •
edited
Loading

Q A
Type feature
BC Break no
Fixed issues -

@lcobucci
Copy link
Member

lcobucci commented Dec 1, 2019

Let's just bump up php version and require phpunit 8. Much easier for everyone 😁

@goetas
Copy link
Member Author

goetas commented Dec 1, 2019

phpunit 8 requires php 7.2, while the minimum version for doctrine migrations is 7.1. Is it ok to increase the min version to 7.2 for this library too?

@goetas goetas mentioned this pull request Dec 1, 2019
Merged
@goetas goetas force-pushed the phpunit-8 branch 2 times, most recently from fb8b640 to b9a5030 Compare December 1, 2019 08:38
@goetas goetas changed the title Allow phpunit 8 Drop php 7.1 and allow phpunit 8 Dec 1, 2019
@goetas goetas requested a review from alcaeus December 1, 2019 08:39
@goetas goetas force-pushed the phpunit-8 branch 2 times, most recently from 7499bf9 to cb2db5f Compare December 1, 2019 08:47
@greg0ire
Copy link
Member

greg0ire commented Dec 1, 2019

Is it ok to increase the min version to 7.2 for this library too?

7.1 is EOL, I think it is ok.

@goetas goetas added this to the 3.0.0 milestone Dec 1, 2019
@goetas
Copy link
Member Author

goetas commented Dec 1, 2019

Is it ok to increase the min version to 7.2 for this library too?

7.1 is EOL, I think it is ok.

Happy to hear that. Build is green!

alcaeus
alcaeus approved these changes Dec 1, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping 7.1 for 3.0 is fine.

@goetas goetas force-pushed the phpunit-8 branch 2 times, most recently from 4871a89 to 8bc683f Compare December 1, 2019 09:28
@greg0ire
Copy link
Member

greg0ire commented Dec 1, 2019

FWIW, I think we could even do this on 2.2.x , not sure what others think.

@goetas
Copy link
Member Author

goetas commented Dec 1, 2019

appveyor is having some issues https://status.chocolatey.org/issues/2019-11-29-slow-and-intermittent-connection-issues/

@goetas goetas merged commit f92df45 into doctrine:master Dec 1, 2019
@alcaeus
Copy link
Member

alcaeus commented Dec 1, 2019

@greg0ire I don’t see a reason to drop 7.1 in 2.x.

@greg0ire
Copy link
Member

greg0ire commented Dec 1, 2019

Allowing new features like the object type declaration in new code could be a reason, but maybe that's something we want to do if and when someone makes a PR that would benefit from such features.

@alcaeus
Copy link
Member

alcaeus commented Dec 1, 2019

We can always do that when the new API shows up.

@goetas goetas deleted the phpunit-8 branch December 1, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@goetas @lcobucci @greg0ire @alcaeus