Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of the visibility from "public" to "protected" on Command folder WIP #923

Closed
wants to merge 1 commit into from

Conversation

Karimgasmi47
Copy link

Change of the visibility from "public" to "protected" on Command classes to match the declaration with Symfony/Console

Q A
Type improvement
BC Break yes

…classes to match the declaration with Symfony/Console
@goetas
Copy link
Member

goetas commented Jan 27, 2020

Thanks for the PR, can you please check the failing tests?

@Karimgasmi47
Copy link
Author

Sure, I'll do it asap

@Karimgasmi47 Karimgasmi47 changed the title Change of the visibility from "public" to "protected" on Command folder Change of the visibility from "public" to "protected" on Command folder WIP Jan 28, 2020
@goetas goetas added this to the 3.0.0 milestone Mar 3, 2020
@goetas
Copy link
Member

goetas commented Mar 4, 2020

done in #938

@goetas goetas closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants