Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the execute() method as protected to match the symfony signature #938

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Mark the execute() method as protected to match the symfony signature #938

merged 1 commit into from
Mar 4, 2020

Conversation

goetas
Copy link
Member

@goetas goetas commented Mar 4, 2020 •
edited
Loading

Q A
Type improvement
BC Break -
Fixed issues #923

Change of the visibility from "public" to "protected" on Command classes to match the declaration with Symfony/Console

Implementation of #923 with tests

@goetas goetas added this to the 3.0.0 milestone Mar 4, 2020
@goetas goetas merged commit f87b808 into doctrine:master Mar 4, 2020
@goetas goetas mentioned this pull request Mar 4, 2020
Closed
@goetas goetas mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@goetas @SenseException