Fix setting readonly properties in different scopes

[chapterjason]

Looks like #10049 can be fixed like this, it simply uses the described method from the RFC by changing the scope to the declaring class.

It will only be executed if the isReadOnly-method is present, this will also check if PHP is 8.1 or higher, I am not sure if there is any performance impact on this.

As I described in the tests/Doctrine/Tests/ORM/Functional/Ticket/GH10049Mocks.php file, it is required to have them outside, otherwise, the file will be fully parsed by PHP 7.4 and will throw an error because the keyword readonly is new and not backwards compatible.

Fixes: #10049

[derrabus]

It will only be executed if the isReadOnly-method is present, this will also check if PHP is 8.1 or higher, I am not sure if there is any performance impact on this.

There is: if (PHP_VERSION_ID >= 80100) can be optimized by the compiler. Apart from that, this check is easier to spot when we drop support for older PHP versions eventually. This is why I would prefer PHP version checks over feature detection in this case.

[chapterjason]

Good to know, thanks, I will adjust that.

[michnovka]

looks ok to me

[MatTheCat]

This PR handles embeddables but other properties also are impacted by #10049 😕

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[github-actions]

This pull request was closed due to inactivity.