Create ReflectionReadonlyProperty from their declaring class so their value can be set
#10666
+80
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatTheCat
force-pushed
the
inherited-readonly-properties
branch
2 times, most recently
from
c30d469 to
f2e335a
Compare
|
You can keep the entity classes and functional tests in a single file, other tests do this as well. Personally, I find it much easier to understand tests when everything is in a single place. |
|
Done; how can I make the CI green for PHP < 8.1? |
MatTheCat
force-pushed
the
inherited-readonly-properties
branch
from
200cb89 to
2261433
Compare
greg0ire
reviewed
May 6, 2023
MatTheCat
force-pushed
the
inherited-readonly-properties
branch
from
2261433 to
6a3c091
Compare
MatTheCat
force-pushed
the
inherited-readonly-properties
branch
from
6a3c091 to
181460b
Compare
|
Okay I followed #10683 (comment) Not sure about the naming though, feel free to suggest. |
MatTheCat
force-pushed
the
inherited-readonly-properties
branch
from
181460b to
b5647c5
Compare
greg0ire
reviewed
May 7, 2023
tests/Doctrine/Tests/ORM/Functional/Ticket/GH10049/SetInheritedReadOnlyPropertyValueTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Tests/ORM/Functional/Ticket/GH10049/SetInheritedReadOnlyPropertyValueTest.php
Outdated
Show resolved
Hide resolved
greg0ire
previously approved these changes
May 7, 2023
greg0ire
reviewed
May 7, 2023
tests/Doctrine/Tests/ORM/Functional/Ticket/GH10049/SetInheritedReadOnlyPropertyValueTest.php
Outdated
Show resolved
Hide resolved
MatTheCat
force-pushed
the
inherited-readonly-properties
branch
from
c3d6594 to
1c8d296
Compare
greg0ire
previously approved these changes
May 7, 2023
|
Sorry when I caused too much confusion by asking for keeping everything in a single file 👌🏻 |
|
No worries, in the end it resulted in a better directory layout for tests IMO. |
MatTheCat
force-pushed
the
inherited-readonly-properties
branch
from
1c8d296 to
2f46e5a
Compare
greg0ire
approved these changes
May 11, 2023
SenseException
approved these changes
May 11, 2023
|
Thanks @MatTheCat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10049 and supersedes #10059.
I must have missed an RFC because from https://wiki.php.net/rfc/readonly_properties_v2#reflection
But that does not seem to be the case. This makes
ReflectionReadonlyProperty::setValue()crash when hydrating an inherited readonly property.This PR makes
ClassMetadataInfobuildReflectionReadonlyPropertywith a property whose class is its declaring one to avoid this issue.