Allow doctrine/instantiator 2
#10351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
allow/instantiator-2
branch
from
4485c5f to
4d3d151
Compare
derrabus
commented
Dec 30, 2022
| @@ -43,7 +43,7 @@ | |||
| "doctrine/coding-standard": "^9.0.2 || ^11.0", | |||
| "phpbench/phpbench": "^0.16.10 || ^1.0 || dev-master", | |||
| "phpstan/phpstan": "~1.4.10 || 1.9.4", | |||
| "phpunit/phpunit": "^7.5 || ^8.5 || ^9.5", | |||
| "phpunit/phpunit": "^7.5 || ^8.5 || ^9.5.28@dev", | |||
There was a problem hiding this comment.
PHPUnit uses doctrine/instantiator as well and would prevent this installation of v2. We can revert back to stable as soon as sebastianbergmann/phpunit#5126 has been released.
greg0ire
approved these changes
Dec 30, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 30, 2022
* 2.15.x: Allow doctrine/instantiator 2 (doctrine#10351)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Dec 31, 2022
* 2.15.x: Shorter deprecation message (doctrine#10357) Add Fully-Qualified class name in UnrecognizedField exception to ease debugging (doctrine#10342) Include parameter types in hydration cache key generation (doctrine#10355) Allow doctrine/instantiator 2 (doctrine#10351)
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctrine/instantiator2 adds some type declarations that should not affect us.