Remove concrete table inheritance #10414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
changed the title
greg0ire
approved these changes
Jan 17, 2023
|
Since it technically a BC break, do we require deprecation warnings or similar in 2.x? |
|
It can't hurt to do so. If you do, you'll have to add something in |
|
I don't know how access to a |
|
For once, we have a clearly documented policy on this: https://www.doctrine-project.org/policies/deprecation.html 🙂 TL;DR: use |
SenseException
approved these changes
Jan 17, 2023
derrabus
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a leftover from early days, but never actually implemented or documented.
#10423 adds the deprecation notices in 2.14.
Closes #7371, references #10217, closes #10220.