Add deprecations for "table per class" inheritance #10423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
force-pushed
the
deprecate-table-type-per-class
branch
from
3694139 to
a2736bb
Compare
mpdude
force-pushed
the
deprecate-table-type-per-class
branch
from
e39c70f to
d6a38b3
Compare
|
Note that we don't do deprecations in bugfix releases. The PR needs to target 2.15.x. Also, please document the deprecation in the upgrade log. |
mpdude
force-pushed
the
deprecate-table-type-per-class
branch
from
d6a38b3 to
89b98bd
Compare
|
Rebased and added a note to the upgrading document |
greg0ire
reviewed
Jan 18, 2023
| <file name="lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php" /> | ||
| <file name="lib/Doctrine/ORM/Tools/EntityGenerator.php" /> | ||
| <file name="lib/Doctrine/ORM/Tools/Export/Driver/AbstractExporter.php" /> | ||
| <file name="lib/Doctrine/ORM/Tools/SchemaTool.php" /> |
There was a problem hiding this comment.
Let's remember to remove these after or during the merge up (and the one below as well)
greg0ire
approved these changes
Jan 18, 2023
SenseException
approved these changes
Jan 18, 2023
|
Thanks @mpdude ! |
greg0ire
reviewed
Jan 18, 2023
| @@ -1,5 +1,15 @@ | |||
| # Upgrade to 2.14 | |||
There was a problem hiding this comment.
#10428 to fix this (already merged here)
mpdude
added a commit
to mpdude/doctrine2
that referenced
this pull request
Jan 19, 2023
This was a mistake in doctrine#10423.
derrabus
pushed a commit
that referenced
this pull request
Jan 19, 2023
This was a mistake in #10423.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements #10414.
I don't see how the
\Doctrine\ORM\Mapping\ClassMetadataInfo::INHERITANCE_TYPE_TABLE_PER_CLASSconstant could be deprecated by itself, but this covers all places where it might reasonably be passed in.