Deprecate usage of @JoinColumn on the inverse side of one-to-one associations
#10654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
changed the title
@JoinColumn on the inverse side of one-to-one associations
mpdude
force-pushed
the
join-column-does-not-make-it-own
branch
from
c870020 to
63ff848
Compare
|
Tests will pass with the changes from #10652. |
derrabus
reviewed
Apr 25, 2023
derrabus
reviewed
Apr 25, 2023
mpdude
force-pushed
the
join-column-does-not-make-it-own
branch
2 times, most recently
from
d7bfd38 to
917a656
Compare
|
Something went wrong when rebasing this PR, apparently. The diff contains changes that have already been merged to 2.15.x. |
mpdude
force-pushed
the
join-column-does-not-make-it-own
branch
from
917a656 to
9b44181
Compare
greg0ire
reviewed
Apr 25, 2023
mpdude
force-pushed
the
join-column-does-not-make-it-own
branch
2 times, most recently
from
14f5b69 to
98177e4
Compare
…ciations Following up on doctrine#10652: #### Current situation The implementation of `\Doctrine\ORM\Mapping\ClassMetadataInfo::_validateAndCompleteOneToOneMapping` will consider a field with a one-to-one association to be the owning side also when it configures `@JoinColumn` settings. #### Suggested change For a one to one association, a field should be the inverse side when it uses the `mappedBy` attribute, and be the owning side otherwise. The `JoinColumn` may be configured on the owning side only. This PR adds a deprecation notice when `@JoinColumn` is used on the side of a one-to-one association where `mappedBy` occurs. In 3.0, this will throw a `MappingException`.
mpdude
force-pushed
the
join-column-does-not-make-it-own
branch
from
98177e4 to
aba8d74
Compare
greg0ire
approved these changes
Apr 26, 2023
|
Thanks @mpdude ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #10652:
Current situation
The implementation of
\Doctrine\ORM\Mapping\ClassMetadataInfo::_validateAndCompleteOneToOneMappingwill consider a field with a one-to-one association to be the owning side also when it configures@JoinColumnsettings.Suggested change
For a one to one association, a field should be the inverse side when it uses the
mappedByattribute, and be the owning side otherwise. TheJoinColumnmay be configured on the owning side only.This PR adds a deprecation notice when
@JoinColumnis used on the side of a one-to-one association wheremappedByoccurs.In 3.0, this will throw a
MappingException.