Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lexer deprecation #10736

Closed
wants to merge 1 commit into from
Closed

Conversation

jmsche
Copy link

@jmsche jmsche commented Jun 1, 2023

Hi,

This (very) small PR to fix a lexer deprecation:

Accessing Doctrine\Common\Lexer\Token properties via ArrayAccess is deprecated, use the value, type or position property instead (Token.php:104 called by Parser.php:585, doctrine/lexer#79, package doctrine/lexer)

I think the fix is okay for 2.15.x branch as it requires doctrine/lexer:^2.

@greg0ire
Copy link
Member

greg0ire commented Jun 1, 2023

Thanks for this, but I'll close in favor of #10737 , which covers more cases.

@greg0ire greg0ire closed this Jun 1, 2023
@jmsche jmsche deleted the fix-lexer-deprecation branch June 1, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants