Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDC-3343] Entities should not be deleted when using EXTRA_LAZY and one-to-many #1169

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 92 additions & 0 deletions tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3343Test.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
<?php

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\Mapping\Column;
use Doctrine\ORM\Mapping\GeneratedValue;
use Doctrine\ORM\Mapping\Id;
use Doctrine\ORM\Mapping\ManyToOne;
use Doctrine\ORM\Mapping\OneToMany;

/**
* @group DDC-3343
*/
class DDC3343Test extends \Doctrine\Tests\OrmFunctionalTestCase
{
public function testEntityNotDeletedWhenRemovedFromExtraLazyAssociation()
{
$this->_schemaTool->createSchema(array(
$this->_em->getClassMetadata(__NAMESPACE__ . '\DDC3343User'),
$this->_em->getClassMetadata(__NAMESPACE__ . '\DDC3343Group'),
));

// Save a group and an associated user (in an extra lazy association)
$group = new DDC3343Group();
$user = new DDC3343User();

$group->users->add($user);

$this->_em->persist($group);
$this->_em->persist($user);
$this->_em->flush();

// Fetch the group and the user again and remove the user from the collection.
$this->_em->clear();

$group = $this->_em->find(__NAMESPACE__ . '\DDC3343Group', $group->id);
$user = $this->_em->find(__NAMESPACE__ . '\DDC3343User', $user->id);

$group->users->removeElement($user);

$this->_em->persist($group);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this persist necessary here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the association is extra lazy, in fact it was not.

$this->_em->flush();

// Even if the collection is extra lazy, the user should not have been deleted.
$this->_em->clear();

$user = $this->_em->find(__NAMESPACE__ . '\DDC3343User', $user->id);
$this->assertNotNull($user);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use assertInstanceOf here

}
}

/**
* @Entity
*/
class DDC3343User
{
/**
* @Id
* @GeneratedValue
* @Column(type="integer")
*/
public $id;

/**
* @ManyToOne(targetEntity="DDC3343Group", inversedBy="users")
*/
protected $group;
}

/**
* @Entity
*/
class DDC3343Group
{
/**
* @Id
* @GeneratedValue
* @Column(type="integer")
*/
public $id;

/**
* @OneToMany(targetEntity="DDC3343User", mappedBy="group", fetch="EXTRA_LAZY")
*/
public $users;

public function __construct()
{
$this->users = new ArrayCollection();
}
}