Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDC-3343] Entities should not be deleted when using EXTRA_LAZY and one-to-many #1169

Closed
wants to merge 2 commits into from
Closed

[DDC-3343] Entities should not be deleted when using EXTRA_LAZY and one-to-many #1169

wants to merge 2 commits into from

Conversation

asprega
Copy link
Contributor

@asprega asprega commented Oct 24, 2014

Here's a failing test case for the issue I filed a few days ago: http://www.doctrine-project.org/jira/browse/DDC-3343

Notifying @Ocramius.

Ocramius
Ocramius reviewed Oct 24, 2014
View reviewed changes
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3343Test.php
$this->_em->clear();

$user = $this->_em->find(__NAMESPACE__ . '\DDC3343User', $user->id);
$this->assertNotNull($user);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use assertInstanceOf here

@echochamber
Copy link

I've experienced this issue as well. Entity mapped with Extra Lazy loading. I want to remove element from a collection on the "One" side of the ManyToOne relationship, but not delete the entity from the database. This issues a delete query to delete the record of entity being removed from the collection when it should actually not issue a query at all (or just null out of the foreign key column).

@asprega
Copy link
Contributor Author

asprega commented Jan 4, 2015

@Ocramius any updates? do you want me to propose a fix?

@Ocramius
Copy link
Member

Ocramius commented Jan 4, 2015

@asprega I didn't check this yet

@Ocramius Ocramius changed the title [DDC-3343] Failing test case [DDC-3343] [Test] Failing test case Jan 16, 2015
@Ocramius Ocramius changed the title [DDC-3343] [Test] Failing test case [DDC-3343] Entities should not be deleted when using EXTRA_LAZY and one-to-many Jan 24, 2015
@Ocramius Ocramius self-assigned this Jan 24, 2015
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - one-to-many extra-lazy should not delete ass…
f184956 
…ociated values when they are removed, but just update the owning side
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - minor refactoring: constant over string refe…
aed01ea 
…rence
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - refactoring test to use pre-existing test mo…
15397bb 
…dels
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - refactoring test to use pre-existing test mo…
43f301f 
…dels
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - optimized imports
ed0331d
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - importing used classe
ff986a9
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - integrating tests into the existing test suite
a8796fa
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - removing duplicate test
99c5650
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - correcting query count assertions on extra-l…
6a2b7c2 
…azy specific tests (some DELETE operations became UPDATE operations)
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - additional test cases: removing proxies from…
d443d4f 
… an extra-lazy collection still updates the owning side values
@Ocramius Ocramius mentioned this pull request Jan 24, 2015
Merged
@Ocramius
Copy link
Member

Moved to #1281

@Ocramius Ocramius closed this Jan 24, 2015
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - minor refactoring: constant over string refe…
24ebfb6 
…rence
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - refactoring test to use pre-existing test m…
7292920 
…odels
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - refactoring test to use pre-existing test mo…
193ec51 
…dels
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - optimized imports
41258de
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 24, 2015
@Ocramius
doctrine#1169 DDC-3343 - importing used classe
d69fd91
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 27, 2015
@Ocramius
doctrine#1169 DDC-3343 - eagerly evicting cache if a persister passes…
a9671fd 
… a delete operation down to the DB
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 27, 2015
@Ocramius
doctrine#1169 DDC-3343 - eagerly evicting cache if a persister passes…
c7a6352 
… a delete operation down to the DB
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Jan 28, 2015
@Ocramius
doctrine#1169 DDC-3343 - removing note about query count assertion
e76b20b
Ocramius added a commit that referenced this pull request Jan 28, 2015
@Ocramius
Merge pull request #1288 from Ocramius/hotfix/#1169-extra-lazy-one-to…
3ed73b4 
…-many-is-noop-when-not-doing-orphan-removal

Hotfix - #1169 - extra lazy one to many must be no-op when not doing orphan removal
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - updating test expectations - one-to-many ch…
579b710 
…anges should be no-op unless orphan removal is specified.
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - updating test expectations - one-to-many ch…
18b067a 
…anges should be no-op unless orphan removal is specified.
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - adding tests for orphan-removal + extra-laz…
16e9513 
…y + one-to-many element removal behavior
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - aligning test suite logic to the 2.5 branch …
f861d74 
…(failing tests)
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - fixing test case typos (referencing wrong/in…
90893ee 
…existing properties, inexisting owning side assigned
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - one-to-many persister should only interact w…
ac1a6ed 
…ith the data when `orphanRemoval` and `EXTRA_LAZY` are combined
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - updating test expectations - one-to-many ch…
af59ea9 
…anges should be no-op unless orphan removal is specified.
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - updating test expectations - one-to-many ch…
94c0e46 
…anges should be no-op unless orphan removal is specified.
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - adding tests for orphan-removal + extra-laz…
cbe5575 
…y + one-to-many element removal behavior
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - aligning test suite logic to the 2.5 branch…
fac410b 
… (failing tests)
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - fixing test case typos (referencing wrong/i…
4884183 
…nexisting properties, inexisting owning side assigned
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - one-to-many persister should only interact …
4bed15b 
…with the data when `orphanRemoval` and `EXTRA_LAZY` are combined
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - removing duplicate test method
c6e7a81
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - remove duplicate tests introduced by cherry-…
c4ab4db 
…picking conflicts
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - actually deleting associated elements when t…
2fa48c6 
…hey are orphaned and EXTRA_LAZY is used
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - optimized imports
a1bd3e8
@Ocramius Ocramius mentioned this pull request Feb 5, 2015
Merged
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - corrected persister logic - only uses the en…
f5705d6 
…tity persister to perform deletes on the owning side
Ocramius added a commit to Ocramius/doctrine2 that referenced this pull request Feb 5, 2015
@Ocramius
doctrine#1169 DDC-3343 - correcting functional test case cleanup logi…
11936a6 
…c (sorting deletes by FK dependencies)
Ocramius added a commit that referenced this pull request Feb 16, 2015
@Ocramius
Merge pull request #1300 from Ocramius/hotfix/#1169-DDC-3343-one-to-m…
18c8732 
…any-persister-deletes-only-on-extra-lazy-plus-orphan-removal-2.4

[2.4] #1169 DDC-3343 one-to-omany persister deletes only on EXTRA_LAZY plus orphanRemoval
This was referenced Dec 6, 2015
Closed
Closed
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Jun 20, 2019
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Nov 14, 2019
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Failing Test Requires merge/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asprega @echochamber @Ocramius