travis: optimize to run coverage only once #1251
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3495 We use Jira to track the state of pull requests and the versions they got |
TomasVotruba
changed the title
| - composer install --prefer-source --dev | ||
|
|
||
| script: | ||
| - ENABLE_SECOND_LEVEL_CACHE=0 ./vendor/bin/phpunit -v -c tests/travis/$DB.travis.xml --coverage-clover ./build/logs/clover.xml | ||
| - ENABLE_SECOND_LEVEL_CACHE=1 ./vendor/bin/phpunit -v -c tests/travis/$DB.travis.xml --coverage-clover ./build/logs/clover-slc.xml --exclude-group performance,non-cacheable,locking_functional | ||
| - if [ $TRAVIS_PHP_VERSION == 'hhvm']; then ENABLE_SECOND_LEVEL_CACHE=0 ./vendor/bin/phpunit -v -c tests/travis/$DB.travis.xml --coverage-clover ./build/logs/clover.xml; fi |
There was a problem hiding this comment.
Can we apply coverage only to 5.6?
There was a problem hiding this comment.
Yep, gotta go now. Will fix later. Also found a typo.
There was a problem hiding this comment.
instead of duplicating the whole command, I would rather export an environment variable PHPUNIT_FLAGS (empty string or --coverage-clover ./build/logs/clover.xml depending of the PHP version) during the before_script and then using it when running the command. this would avoid having to keep methods in sync
There was a problem hiding this comment.
@stof Neat idea, thanks. I'll try to implement it.
|
All looks fine now. I've narrowed coverage to PHP 5.6 and sqlite, as it seems the fastest combination. Could re-check please? |
|
Great work @TomasVotruba 👍 |
|
Very good! Merging! |
travis: optimize to run coverage only once
|
Thank you and thanks @stof for nice idea. |
| - if [ $DB = 'pgsql' ]; then psql -c 'DROP DATABASE IF EXISTS doctrine_tests_tmp;' -U postgres; fi | ||
| - if [ $DB = 'pgsql' ]; then psql -c 'create database doctrine_tests;' -U postgres; fi | ||
| - if [ $DB = 'pgsql' ]; then psql -c 'create database doctrine_tests_tmp;' -U postgres; fi | ||
| - if [ $DB = 'mysql' ]; then mysql -e 'create database IF NOT EXISTS doctrine_tests_tmp;create database IF NOT EXISTS doctrine_tests;'; fi |
There was a problem hiding this comment.
These DB related CREATE/DROP commands can potentially be eliminated, too like in DBAL: doctrine/dbal@a660106
There was a problem hiding this comment.
Shall I send PR? If so, to all 2.5-2.1 branches?
Ref: Ocramius/Instantiator#17
Before: ~3,5 hours
Now: ~52 min
So what do you think?