travis: optimize to run coverage only once #1251
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,16 +14,17 @@ env: | |
| - DB=sqlite | ||
|
|
||
| before_script: | ||
| - if [[ $TRAVIS_PHP_VERSION = '5.6' && $DB = 'sqlite' ]]; then PHPUNIT_FLAGS="--coverage-clover ./build/logs/clover.xml"; else PHPUNIT_FLAGS=""; fi | ||
| - if [ $DB = 'pgsql' ]; then psql -c 'DROP DATABASE IF EXISTS doctrine_tests;' -U postgres; fi | ||
| - if [ $DB = 'pgsql' ]; then psql -c 'DROP DATABASE IF EXISTS doctrine_tests_tmp;' -U postgres; fi | ||
| - if [ $DB = 'pgsql' ]; then psql -c 'create database doctrine_tests;' -U postgres; fi | ||
| - if [ $DB = 'pgsql' ]; then psql -c 'create database doctrine_tests_tmp;' -U postgres; fi | ||
| - if [ $DB = 'mysql' ]; then mysql -e 'create database IF NOT EXISTS doctrine_tests_tmp;create database IF NOT EXISTS doctrine_tests;'; fi | ||
| - composer install --prefer-source --dev | ||
|
|
||
| script: | ||
| - ENABLE_SECOND_LEVEL_CACHE=0 ./vendor/bin/phpunit -v -c tests/travis/$DB.travis.xml $PHPUNIT_FLAGS | ||
| - ENABLE_SECOND_LEVEL_CACHE=1 ./vendor/bin/phpunit -v -c tests/travis/$DB.travis.xml --exclude-group performance,non-cacheable,locking_functional | ||
|
There was a problem hiding this comment. removing the code coverage here is wrong. Running the testsuite with SLC enabled runs different code paths, which is why we are running both (and then uploading both code coverage reports so that they get merged). Btw, running the code coverage only for SQLite might also miss some code coverage There was a problem hiding this comment. There are different code paths for nearly all of the DBAL platforms... There was a problem hiding this comment. @stof I see it took down about 0.2 % of coverage. What do you suggest? There was a problem hiding this comment. @Ocramius Great, I see it same way :) |
||
|
|
||
| after_script: | ||
| - php vendor/bin/coveralls -v | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These DB related CREATE/DROP commands can potentially be eliminated, too like in DBAL: doctrine/dbal@a660106
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I send PR? If so, to all 2.5-2.1 branches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just
masteris fine