Updated syntax for "integer" and "boolean" types

[phansys]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Used short syntax for integer and boolean types.

Before

/**
 * @var integer
 *
 * @ORM\Column(name="some_integer_field", type="integer")
 */
private $someIntegerField;

/**
 * @var boolean
 *
 * @ORM\Column(name="some_boolean_field", type="boolean")
 */
private $someBooleanField;

After

/**
 * @var int
 *
 * @ORM\Column(name="some_integer_field", type="integer")
 */
private $someIntegerField;

/**
 * @var bool
 *
 * @ORM\Column(name="some_boolean_field", type="boolean")
 */
private $someBooleanField;

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3824

We use Jira to track the state of pull requests and the versions they got
included in.

[TomasVotruba]

This seems ready.

[holtkamp]

Just wondering, what is the added value of 'going back to abbreviations'? Preparing for PHP7 type hinting?

[TomasVotruba]

@holtkamp Might be. Consistency improves readability and also prevents confusion. It would be also easier to adapt PHP 7 type hinting, as you state.

[holtkamp]

@TomasVotruba personally I regard abbreviations something that should only be used when needed (for example when there is insufficient space on a piece of paper, one uses an abbreviation). Alias functions like is_integer() triggered me to prefer the 'integer' over 'int' notation, hoping that one day we would also have an is_boolean() function.

About the consistency:

/**
 * @var bool
 *
 * @ORM\Column(name="some_boolean_field", type="boolean")
 */
private $someBooleanField;

I see 1x bool and 3x boolean...

Might be my personal glitch, but I would say 👎

[TomasVotruba]

@holtkamp I have no opinion about this, it doesn't burn me. Just seems ready.

[deeky666]

@holtkamp these abbreviations are also used in the upcoming PSR-5: PHPDoc standard. So IMO this PR is a good thing.

[Majkl578]

@holtkamp:

I see 1x bool and 3x boolean...

How often do you add type name into the variable name? That seems crazy. In real world, you'd have something like:

/**
 * @var bool
 * @ORM\Column(name="is_enabled", type="boolean")
 */
private $enabled;

1x bool and 1x boolean.

It's sad that Doctrine doesn't support both variants, but that's for another discussion.

[TomasVotruba]

👍 Thanks guys

[Ocramius]

It's sad that Doctrine doesn't support both variants, but that's for another discussion.

Meh, we have more relevant stuff to deal with anyway.

[holtkamp]

@deeky666 aah, nice, did not know that PSR yet
@Majkl578 true
@Ocramius so true

I stand corrected 😄