This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
[minor] Conversion to "int" and "bool" for Doctrine generated entities #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phansys
commented
Jul 20, 2015
phansys
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
Thanks for this commit. I like the idea behind it, but it looks like a hack. Apparently the code we are fixing is the same code that we generated (via Doctrine libraries). It's strange that we generate wrong code in the first place 😕 |
|
Thank you for the feedback @javiereguiluz. I've created a PR last week against Doctrine in order to "fix" this into the library itself: doctrine/orm#1457. I'm quoting fix because this CS rule isn't part of Doctrine's CSs: |
|
👍 then it looks like this is the only safe way to solve this issue. Thanks. |
| @@ -88,6 +88,11 @@ public function generate(BundleInterface $bundle, $entity, $format, array $field | |||
| $entityGenerator->setGenerateAnnotations(false); | |||
| $entityCode = $entityGenerator->generateEntityClass($class); | |||
| } | |||
| $entityCode = str_replace( | |||
| array("@var integer\n", "@var boolean\n", "@param integer\n", "@param boolean\n", "return integer\n", "return boolean\n"), | |||
| array("@var int\n", "@var bool\n", "@param int\n", "@param bool\n", "return int\n", "return bool\n"), | |||
There was a problem hiding this comment.
Why didn't you put a @ in front of return?
There was a problem hiding this comment.
I don't know @xabbuh :P (copy - paste typo). Fixed.
… entities | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR |
phansys
force-pushed
the
entities_bool_int
branch
from
9c07bc8 to
6ff93e9
Compare
|
Thanks @phansys. |
javiereguiluz
added a commit
that referenced
this pull request
Jul 22, 2015
…ted entities (phansys) This PR was merged into the 3.0.x-dev branch. Discussion ---------- [minor] Conversion to "int" and "bool" for Doctrine generated entities | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 6ff93e9 [minor] Conversion to ```int``` and ```bool``` for Doctrine generated entities
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.