DDC-3146 Remove onClear event listener from abstract hydrator in cleanup function, otherwise causing hydrator GC to not kick in
#1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or in cleanup function
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3914 We use Jira to track the state of pull requests and the versions they got |
|
@emiel-silverstreet the fix looks good, but:
|
Ocramius
added a commit
that referenced
this pull request
Jun 24, 2017
…' into 2.5 Close #1515 This is a backport of the original PR - the same patch should land in `master` too, after a cleanup
Ocramius
added a commit
that referenced
this pull request
Jun 24, 2017
Ocramius
added a commit
that referenced
this pull request
Jun 24, 2017
Ocramius
added a commit
that referenced
this pull request
Jun 24, 2017
Ocramius
added a commit
that referenced
this pull request
Jun 24, 2017
This was referenced Jun 24, 2017
Ocramius
changed the title
onClear event listener from abstract hydrator in cleanup function, otherwise causing hydrator GC to not kick in
|
Overlooked method hydrateAll()? PR: #6623 |
Ocramius
added a commit
that referenced
this pull request
Aug 16, 2017
…ns-up-on-unit-of-work-clear-2.5' into 2.5 Close #6623
Ocramius
added a commit
that referenced
this pull request
Aug 16, 2017
…ns-up-on-unit-of-work-clear' Close #6623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the iterate function is invoked an event listener is added, but never removed. This will keep a reference to the abstract hydrator in the event manager, which will prevent the php garbage collector from removing the instance. When used multiple times this will create a memory leak because the event manager will be filled with references to unused hydrators. This fix will remove the event listener in the cleanup function which is invoked when the hydrator is finished, allowing the class to be garbage collected.