Ensure that AbstractHydrator#hydrateAll() detaches the hydrator from the event manager
#6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@echo511 this still requires a test case |
|
@Ocramius OK, I'll do it as a fix of DDC-3146 and its test case? Where should it go? On top of 2.5.8? |
|
@echo511 all patches should go against |
# Conflicts: # tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3146Test.php
Ocramius
changed the title
AbstractHydrator#hydrateAll() detaches the hydrator from the event manager
Ocramius
added a commit
that referenced
this pull request
Aug 16, 2017
…ns-up-on-unit-of-work-clear-2.5' into 2.5 Close #6623
Ocramius
added a commit
that referenced
this pull request
Aug 16, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 16, 2017
Ocramius
added a commit
that referenced
this pull request
Aug 16, 2017
…ns-up-on-unit-of-work-clear' Close #6623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think someone overlooked hydrateAll() method and edited only iterate(). #1515
As a result an event listener is not added which can cause problems if EventManager implementation does not check for existence of a listener upon its removal.
In my case it causes E_NOTICE (undefined index) because of https://github.com/Kdyby/Events/blob/master/src/Events/EventManager.php#L198
If my PR should be altered (commit message, etc.) please let me know.