Check requirements for metadata drivers #9452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
greg0ire
reviewed
Jan 31, 2022
greg0ire
reviewed
Jan 31, 2022
greg0ire
reviewed
Jan 31, 2022
derrabus
force-pushed
the
improvement/check-md-driver-reqs
branch
from
15e4141 to
d0d92c7
Compare
greg0ire
approved these changes
Feb 1, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Feb 1, 2022
* 2.11.x: Check requirements for metadata drivers (doctrine#9452) Remove trailing underscore (doctrine#9446)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Feb 1, 2022
* 2.11.x: PDO is not a required extension (doctrine#9457) Check requirements for metadata drivers (doctrine#9452) Remove trailing underscore (doctrine#9446)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Feb 1, 2022
* 2.12.x: Check requirements for metadata drivers (doctrine#9459) PDO is not a required extension (doctrine#9457) Check requirements for metadata drivers (doctrine#9452) Remove trailing underscore (doctrine#9446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9449, replaces #9416.
Our metadata drivers require additional dependencies. If those are not met, the user receives a cryptic error message instead of a helpful one. Especially regarding Doctrine Annotations, I consider this to be a bug because
doctrine/annotationsused to be a mandatory dependency.Please review thoroughly. Except for the attribute driver, our current CI setup does not allow me to test code that reacts to the missing dependencies.