-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ability to merge detached entities #9488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Feb 8, 2022
*/ | ||
public function merge($entity): object | ||
public function merge($object): object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep the method for compatibility with Persistence 2. We can drop it as soon as we move to Persistence >= 3.
Merged
greg0ire
approved these changes
Feb 8, 2022
SenseException
approved these changes
Feb 8, 2022
mpdude
added a commit
to mpdude/doctrine2
that referenced
this pull request
Jun 23, 2023
`EntityManager::merge()` has been deprecated in doctrine#8461 and removed in doctrine#9488. This PR removes a few remaining references and artefacts that - to my understanding - refer to it.
mpdude
added a commit
to mpdude/doctrine2
that referenced
this pull request
Jun 24, 2023
`EntityManager::merge()` has been deprecated in doctrine#8461 and removed in doctrine#9488. This PR removes a few remaining references and artefacts that - to my understanding - refer to it.
mpdude
added a commit
to mpdude/doctrine2
that referenced
this pull request
Jun 24, 2023
`EntityManager::merge()` has been deprecated in doctrine#8461 and removed in doctrine#9488. This PR removes a few remaining references and artefacts that - to my understanding - refer to it.
mpdude
added a commit
to mpdude/doctrine2
that referenced
this pull request
Jun 25, 2023
`EntityManager::merge()` has been deprecated in doctrine#8461 and removed in doctrine#9488. This PR removes a few remaining references and artefacts that - to my understanding - refer to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EntityManager::merge()
method has been deprecated for a long time (#7901). This PR removes this feature from the 3.0 branch.