Remove last references to ClassMetadataInfo

[greg0ire]

It has been deprecated for a long, long time.

ClassMetadataInfo itself is left to avoid conflict. It shall be removed right before releasing 3.0.0

[SenseException]

I'm not sure what "Usage could be localized" means.

[greg0ire]

🤔 me neither

[derrabus]

This change will be a PITA for future merge-ups. 😓

[greg0ire]

@derrabus you mean when touching CMI? Git detected it as a rename, so it should be transparent.

[derrabus]

Are you sure? Unless GitHub has a very strage way to display a file rename, it looks like a big code chunk has been moved from one class to another.

[greg0ire]

It's a bit confusing: git show --summary does not show the rename, yet when I amend the commit, I get this:

[remove-cmi 952ccd103] Remove ClassMetadataInfo
 Author: Grégoire Paris <[email protected]>
 Date: Sun May 1 23:06:22 2022 +0200
 11 files changed, 28 insertions(+), 65 deletions(-)
 rename lib/Doctrine/ORM/Mapping/{ClassMetadataInfo.php => ClassMetadata.php} (99%)

Let me try doing a local merge up.

[greg0ire]

When trying a local merge up, there is indeed a conflict, where none of the choices are good (I get a choice between deleted file and modified file, but CM is not modified when I pick "deleted file")

[greg0ire]

I tried removing ClassMetadata, it helps with git show --summary but not with the merge up or with Github

[greg0ire]

@derrabus I've postponed the removal of CMI itself, the rest can go now IMO.