Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force users to accept the privacy policy #3803

Closed
wants to merge 11 commits into from

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jul 12, 2022

This pull request forces users to accept the privacy policy before they can use dodona.

On most pages users are redirected to this prompt, unless they have already accepted it:
image

Open questions:

  • Do we want to include a (short) version of the privacy policy in the prompt?
  • Do we want to force the prompt upon all users or only upon personal users?

Part of #2597

@jorg-vr jorg-vr added the feature New feature or request label Jul 12, 2022
@jorg-vr jorg-vr self-assigned this Jul 12, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2022

This pull request introduces 1 alert when merging b0630d9 into e316995 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@jorg-vr jorg-vr changed the title Allow users to accept the privacy policy Force users to accept the privacy policy Jul 13, 2022
@jorg-vr jorg-vr temporarily deployed to naos July 13, 2022 12:04 Inactive
This was referenced Jul 15, 2022
@jorg-vr jorg-vr marked this pull request as ready for review August 2, 2022 13:40
@jorg-vr jorg-vr requested a review from a team as a code owner August 2, 2022 13:40
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team August 2, 2022 13:40
@jorg-vr jorg-vr marked this pull request as draft August 3, 2022 07:54
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Aug 3, 2022

The way this is implemented right now this check happens after sign in (Or after account creation)

While writing the new privacy policy, I have come to the realization that it should probably be part of the sign up process. This way no account would be created if the privacy policy is not accepted..

I'll update this

@chvp chvp removed their request for review August 3, 2022 12:17
@jorg-vr jorg-vr changed the base branch from develop to feature/personal-accounts August 3, 2022 13:38
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Aug 16, 2022

closed in favor of #3859

@jorg-vr jorg-vr closed this Aug 16, 2022
@jorg-vr jorg-vr deleted the feature/terms-of-service branch December 6, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant