-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force new private users to accept the privacy policy before creating an account #3859
Merged
jorg-vr
merged 15 commits into
feature/personal-accounts
from
feature/force-privacy-policy
Aug 18, 2022
Merged
Force new private users to accept the privacy policy before creating an account #3859
jorg-vr
merged 15 commits into
feature/personal-accounts
from
feature/force-privacy-policy
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
August 4, 2022 12:09
niknetniko
requested changes
Aug 5, 2022
Co-authored-by: Niko Strijbol <[email protected]>
niknetniko
approved these changes
Aug 5, 2022
1 task
chvp
reviewed
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but if I understood correctly this will be changed to not force an accept for institutional users?
@chvp yes I will update this, so that the new behavior only applies for personal accounts |
2 tasks
jorg-vr
changed the base branch from
feature/personal-accounts
to
feature/allow-personal-users
August 16, 2022 13:35
jorg-vr
changed the title
Force new users to accept the privacy policy before creating an account
Force new private users to accept the privacy policy before creating an account
Aug 16, 2022
bmesuere
approved these changes
Aug 16, 2022
chvp
approved these changes
Aug 16, 2022
Base automatically changed from
feature/allow-personal-users
to
feature/personal-accounts
August 18, 2022 08:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request forces new private users to accept the privacy policy before creating an account. Replaces #3803
Institutional users can still sign up without prompt.
Part of #2597 .