Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildFromCargo nix package #23

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Conversation

Ben-PH
Copy link
Contributor

@Ben-PH Ben-PH commented Oct 9, 2024

This documents how those using nix, or are in NixOS can install the dora CLI app.

This is a best effort, and I can't say whether or not someone that is experienced with nix would ping something in this PR. It works for me, and would like to offer to upstream the fruits of my efforts.

Hold off on doing anything until this is resolved:

dora-rs/dora#685

@Ben-PH Ben-PH marked this pull request as draft October 9, 2024 17:04
@Ben-PH
Copy link
Contributor Author

Ben-PH commented Oct 9, 2024

At the moment, this is how it works for me. I'm in the process of working out a better, more nixey way to do this.

Perhaps this can be a forum to discuss nix support in the meantime?

@Ben-PH
Copy link
Contributor Author

Ben-PH commented Oct 10, 2024

Update: the latest commit accounts for the merging of dora-rs/dora#685

@Ben-PH Ben-PH marked this pull request as ready for review October 10, 2024 12:51
Copy link
Contributor

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nix! 🔥

Thanks :)

@Ben-PH
Copy link
Contributor Author

Ben-PH commented Oct 11, 2024

I don't have write access, so can't merge it. Merge/close at your leisure. I don't see myself being enough involved to warrent adding me to the write-access group.

@haixuanTao haixuanTao merged commit 9f05eb9 into dora-rs:main Oct 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants